Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

!fix(erc712): support MsgCreateValidator #1346

Merged
merged 7 commits into from
Sep 17, 2022
Merged

!fix(erc712): support MsgCreateValidator #1346

merged 7 commits into from
Sep 17, 2022

Conversation

ramacarlucho
Copy link
Contributor

Closes: #XXX

Description

The eip712 was missing some types necessary for the createValidator msg.
Added tests for several msgs for eip712.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ramacarlucho ramacarlucho requested a review from a team as a code owner September 16, 2022 12:14
@ramacarlucho ramacarlucho requested review from 0a1c and adisaran64 and removed request for a team September 16, 2022 12:14
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1346 (406053a) into main (5c80a55) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1346      +/-   ##
==========================================
- Coverage   54.79%   54.77%   -0.03%     
==========================================
  Files         107      107              
  Lines        9990     9994       +4     
==========================================
  Hits         5474     5474              
- Misses       4245     4249       +4     
  Partials      271      271              
Impacted Files Coverage Δ
ethereum/eip712/eip712.go 0.00% <0.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

@fedekunze fedekunze added this to the v0.20.x milestone Sep 16, 2022
@fedekunze fedekunze changed the title Fix for eip712 create validator msg and tests !fix(erc712): support MsgCreateValidator Sep 17, 2022
@fedekunze fedekunze enabled auto-merge (squash) September 17, 2022 07:37
@fedekunze fedekunze merged commit cae7c4d into main Sep 17, 2022
@fedekunze fedekunze deleted the rama/eip712_fix branch September 17, 2022 13:37
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants