Use eval instead of exec; Enable tty for the shell #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnickolay
commented
Dec 1, 2019
| ` + autoInstall(hookName, fs) + "\n" + "cmd=\"lefthook run " + hookName + " $@\"" + | ||
| ` | ||
|
|
||
| if lefthook >/dev/null 2>&1 | ||
| then | ||
| exec $cmd | ||
| eval $cmd |
There was a problem hiding this comment.
Here is the reason of this change https://unix.stackexchange.com/a/296842
ssnickolay
commented
Dec 1, 2019
| @@ -64,12 +64,15 @@ func addHook(hookName string, fs afero.Fs) { | |||
| if [ "$LEFTHOOK" = "0" ]; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
| exec < /dev/tty # <- enables interactive shell | |||
There was a problem hiding this comment.
This is useful if you run interactive scripts by pre-commit hook https://unix.stackexchange.com/a/91716
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are minor changes to support interactive pre-commit scripts.