Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full support for interactive commands and scripts #352

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Full support for interactive commands and scripts #352

merged 3 commits into from
Nov 4, 2022

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Nov 4, 2022 •
edited
Loading

Closes #125

🔧 Summary

  • Don't use PTY if interactive option is set.
  • Don't run interactive commands/scripts in parallel

@mrexox mrexox marked this pull request as ready for review November 4, 2022 09:49
@mrexox mrexox merged commit 06b4a04 into evilmartians:master Nov 4, 2022
@mrexox mrexox deleted the fix/full-support-for-interactive-commands-and-scripts branch November 4, 2022 09:55
mrexox added a commit that referenced this pull request Nov 4, 2022
@mrexox
fix: Full support for interactive commands and scripts (#352)
1ec41a1 
Fixed `interactive` feature with parallel execution. Also now we don't suppress STDOUT and correctly redirect STDIN to TTY.

May not work for Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support interactive commands
1 participant
@mrexox