Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from #314 (chmod missed fix) #330

Merged
merged 3 commits into from
Sep 28, 2022

Commits on Sep 23, 2022

  1. Fix regression from evilmartians#314 (chmod missed fix)

    evilmartians#314 introduced a [regression](evilmartians#314 (comment)) that passes quoted paths to `fs.chmod`.
    [`fs.Chmod`/`os.chmod` on windows](https://cs.opensource.google/go/go/+/master:src/syscall/syscall_windows.go;l=647;drc=242adb784cd64265ce803f6b0c59dbf126bcda9c) calls into the [`GetFileAttributes`](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfileattributesw)/[`SetFileAttributes`](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-setfileattributesw) win32 api directly. The win32 api expects a "strongly typed" path, without quotes, unlike a command line string, and doesn't try to *parse* it. Passing quoted paths to fs.Chmod causes the operation to fail - valid paths do not begin with quotes!
    
    This change moves the path quoting down into `runScript`, so that we can pass the UNquoted path to `fs.Chmod`.
    
    To my great surprise, it looks like go does NOT check `GetLastError` when `GetFileAttributes`/`SetFileAttributes` fails? This is disappointing, because somewhere down the stack, procmon says windows returns "NAME INVALID", which is probably `STATUS_OBJECT_NAME_INVALID`. Poking around kernelbase.dll in GHIDRA shows a couple places where it sets last error, and you can see plenty more in the ReactOS sources.
    ariccio committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    6c15869 View commit details
    Browse the repository at this point in the history
  2. remove unused dir param.

    ariccio committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e497ee6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Move quotedScriptPath initialization near actual use

    Believe it or not, I'm NOT a C89 programmer, I hate code that initializes variables at the top of the block. And yet, here I am. *Something something cobblers kids have no shoes something*
    ariccio committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    4e2c42a View commit details
    Browse the repository at this point in the history