Fix ReadModelSqlGenerator column prefix and suffix usage [Copilot workspare test] #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1002
This pull request addresses the issue with the
ReadModelSqlGeneratornot correctly applying column prefix and suffix in the select query for PostgreSQL read models. The changes ensure that column and table identifiers are properly quoted according to PostgreSQL standards, thus resolving the error encountered when working with read models.CreateSelectSqlmethod inReadModelSqlGenerator.csto utilizeColumnQuotedIdentifierPrefixandColumnQuotedIdentifierSuffixfor column names, ensuring all column names in the SELECT query are correctly quoted.ReadModelSqlGeneratorTests.csunderEventFlow.PostgreSql.Teststo verify thatPostgresReadModelSqlGeneratorcorrectly applies column prefixes and suffixes in SELECT, INSERT, UPDATE, and DELETE queries.For more details, open the Copilot Workspace session.