Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Spanish L10n #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Manolomon
Copy link

Hi 👋, I'm Manuel.

First of all, I found your project repository while looking for some PSP open source games. Congratulations on such an amazing and entertaining experience!, and thank you for contributing to keeping alive this platform, as well as the GBA.

I realize that the Spanish translation isn't finished yet, so I (native in Spanish) am sending this first commit to hopefully, help to complete it. However, I need some additional information (mostly related to the gender of some substantives, to accurately portray their identity, as I wouldn't risk assuming them). Such characters would be:

  • The Wanderer
  • Gatekeeper
  • The Twins
  • Scavenger
  • Engineer (from Engineer's notebook)
  • Worker (from Worker's notebook)

In the case of the notebooks, I opt to name them as departments instead of substantives, i.e. Libreta de Ingeniería would literally translate to Engineering Notebook, and Libreta de Trabajo to Work Notebook. I would like to know your opinion on this matter.

Additionally, I didn't translate the word waypoint for there is not a concise translation that fits this context, the closest I could think about was Punto de Control, which is more often translated as checkpoint.

Finally, I couldn't find the strings bound to the text on the closed-up pictures (like the bag of seeds or the old poster). I'm not sure how to contribute to this.

Feel free to code-review the changes. I'm looking forward to your response.

P.S. I did make 5 changes on the English file, for some minor typos.

Add Spanish translation with some minor questions for the author.
Fix some minor typos on the English String as well
@evanbowman
Copy link
Owner

evanbowman commented Jul 6, 2021

Thanks for working on this translation! I'm really busy this week, but I'll try to review your work soon. Edit: your changes look good at first glance.

For the images with text inside of them, look in this directory:
https://github.com/evanbowman/blind-jump-portable/tree/master/images

All of the image filenames that include an _chinese or an _russian were previously localized into different languages. We will need to translate these same image files into spanish. For headings, I generally used the Futura font, and I used the Bodoni font for smaller text.

Finally, we'll need to add an option for spanish to this config file:
https://github.com/evanbowman/blind-jump-portable/blob/master/scripts/init.lisp#L15

@evanbowman
Copy link
Owner

And when we've worked through all of the previous things, we'll need to build the ROM and do some QA testing, to make sure that all the text fits correctly in various parts of the UI. But if everything looks good, I'll happily merge your contributions.

For the characters, gender is generally unimportant to the story, and you can pick arbitrary gender pronouns for the Spanish translation. Actually, make the engineer female.

@Manolomon Manolomon changed the title [WIP] Add Spanish L18n [WIP] Add Spanish L10n Jul 6, 2021
Except for the seeds package due to missing font
@Manolomon
Copy link
Author

Hey @evanbowman, thanks for the feedback!

I just updated the PR with the new images in Spanish for blaster_info.png, old_poster.png, and postal_advert.png. The image seed_packet.png isn't there since neither Futura nor Bodoni seemed to match the original font in the body.

I hope to add the new language to init.lisp and test the strings this weekend since I couldn't run the Docker image locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants