Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #24, #27, #28 #29

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Fix issues #24, #27, #28 #29

merged 6 commits into from
Nov 27, 2019

Conversation

mp035
Copy link
Contributor

@mp035 mp035 commented Nov 27, 2019

This fixes timeout issues and windows compilation on Nim 1.0. The USB enumeration via registry scanning will come in a separate pull request because it will involve a lot more testing.

Copy link
Owner

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. Just a minor question relating to handling of stop bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants