clearer names in code examples

euZebe · May 22, 2018 · 5a108e5 · 5a108e5
1 parent bbdd905
commit 5a108e5
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 11 deletions.
diff --git a/src/molkky-vanilla-redux.js b/src/molkky-vanilla-redux.js
@@ -111,14 +111,14 @@ function rootReducer(previousState = {}, action) {
  };
 
  // FIXME: unpure reducer: state mutated => audience and referee won't see the action
- // state[player].score += fallenPins.length;
- // state[player].consecutiveFailures = 0;
- // state.fallenPins = fallenPins.length;
- // return state;
+ previousState[player].score += fallenPins.length;
+ previousState[player].consecutiveFailures = 0;
+ previousState.fallenPins = fallenPins.length;
+ return previousState;
 
  // FIXME: unpure reducer: nested state mutated => player listener won't see the action
  // FIXME: !! BobListener listens modifications on Bob's substate
- // const nextState = { ...state, fallenPins: fallenPins.length };
+ // const nextState = { ...previousState, fallenPins: fallenPins.length };
  // nextState[player].consecutiveFailures = 0;
  // nextState[player].score += fallenPins.length;
  // return nextState;
@@ -165,7 +165,7 @@ const crowd = () => {
  const fallenPinsOnLastThrow = nextState.fallenPins;
  if (fallenPinsOnLastThrow) {
  console.log('Spectateurs: 👏👏👏👏\n');
- } else {
+ } else if (fallenPinsOnLastThrow === 0) {
  console.log('Spectateurs: 😞\n');
  }
  } else {

diff --git a/src/store/articles.spec.js b/src/store/articles.spec.js
@@ -1,11 +1,11 @@
 import { createStore } from 'redux';
 import deepFreeze from 'deep-freeze';
 import { createArticle, getArticlesSortedByCreationDate, getLastModification } from './articles';
-import reducers from './reducers';
+import reducer from './reducers';
 
 describe('articles duck', () => {
  test('should update last modification when an article is added', () => {
- const store = createStore(reducers);
+ const store = createStore(reducer);
  const previousState = deepFreeze(store.getState());
  expect(getLastModification(previousState)).toBeNull();
  expect(getArticlesSortedByCreationDate(previousState)).toHaveLength(0);

diff --git a/src/store/configureStore.js b/src/store/configureStore.js
@@ -16,9 +16,9 @@ export default function configureStore(initialState) {
  );
 
  // if (module.hot) {
- // // Enable Webpack hot module replacement for reducers
- // module.hot.accept('../reducers', () => {
- // const nextReducer = require('../reducers')
+ // // Enable Webpack hot module replacement for reducer
+ // module.hot.accept('../reducer', () => {
+ // const nextReducer = require('../reducer')
  // store.replaceReducer(nextReducer)
  // })
  // }

diff --git a/talk/css/custom.css b/talk/css/custom.css
@@ -20,4 +20,8 @@ section.only-image.present > p > img {
 .no-border-image {
  border: unset !important;
  background-color: transparent !important;
+}
+
+.align-right {
+ text-align: right;
 }
diff --git a/talk/resources/content.md b/talk/resources/content.md
@@ -1,6 +1,9 @@
 # Redux
 ## bonnes pratiques
+___
+Jean Martineau-Figuette <!-- .element class="align-right" -->
 
+22 mai 2018 <!-- .element class="align-right" -->
 Note:
 couper le téléphone