-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Mega EOF #3440
Draft
jochem-brouwer
wants to merge
62
commits into
master
Choose a base branch
from
MEGA-EOF-V2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement Mega EOF #3440
+9,682
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
reviewed
Jun 4, 2024
console.log(JSON.stringify(stackDelta)) | ||
|
||
|
||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we put this generation code into evm/scripts
and then reference from here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, good point, will do!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ipsilon/eof/blob/main/spec/eof.md
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7692.md
Not ready for review yet, there is still a lot left to do.
I have some local changes which are super dirty and I did not push yet, but will do once I've cleaned that up (mainly in execution).
To run tests: (note: this setups both blockchain/state and header tests)
execution-spec-tests
, e.g. https://github.com/ethereum/execution-spec-tests/releases/tag/eip7692%40v1.0.4./packages/ethereum-tests
, for instance inside the "eof" folder./packages/vm
:npm run test:blockchain -- --fork=Prague --dir=../eof/fixtures/blockchain_tests
./packages/vm
:npm run test:blockchain -- --fork=Prague --dir=../eof/fixtures/state_tests
./packages/evm/test/eips/eof-header-validation.spec.ts
to maketestDir
point to the right directory, change line 11 to:const testDir = path.resolve('../ethereum-tests/eof/fixtures/eof_tests')
cd ./packages/evm
:npx vitest run ./test/eips/eof-header-validation.spec.ts
Gotchas:
eof-tests
in the above listed fixtures. These are actual header tests, and these verify if the EOF containers are correctCode gotchas:
CALLF
) will save the correct pc once returned, and will update the pc to the start of the called code sectionEXT*CALL
which should put1
on the stack, this sets a special flag formessageGasLimit
of-BIGINT_1
(yes, negative), this is also somewhat a hack (we can provide an extra flag)