-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails to clear mapping storage slots #257
Comments
It would be very beneficial creating actual test cases for these and submitting them to https://github.com/ethereum/tests. ethereumjs-vm passes those tests and if they are actually bugs, they should be part of the official test suite. This applies to the other issue too. |
Agreed, though I'm somewhat time-limited at the moment. I'll do my best to circle back around to this in the next couple weeks if nobody else picks it up in the interim. |
cc @winsvega |
"The other one" was #255 |
Looks like a solidity issue |
I checked this problem and here is what I've found so far: When you clear storage you get gas refund, so, when ganache executes eth_estimateGas the estimated gas considers the gas refund and at the end the total gas is less than the base fee, this is why when executing the real transaction with a low gas limit ethereumjs-vm is throwing that error. Should ganache check that the estimated gas is not lower than the base fee? |
Gas refunds should not be taken int consideration by |
this would be a good test case for the |
Referenced Ganache issue is now closed, seemed to be VM unrelated. Will close, feel free to reopen if necessary. |
Another one from our archives which is likely misattributed to Ganache: trufflesuite/ganache#294
The text was updated successfully, but these errors were encountered: