Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce YulNameRepository #15242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Introduce YulNameRepository #15242

wants to merge 1 commit into from
+308 −0

Conversation

clonker
Copy link
Member

@clonker clonker commented Jul 5, 2024 •
edited
Loading

an appending datastructure, in which id hierarchies can be defined as singly linked lists

This PR extracted from PR #15215

Commit with YulNameRepository in action: e16ff50

@clonker clonker self-assigned this Jul 8, 2024
@clonker clonker requested a review from r0qs July 8, 2024 13:24
r0qs
r0qs reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've left some comments but haven’t finished reading through it yet.

libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.h Outdated Show resolved Hide resolved
r0qs
r0qs reviewed Jul 9, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
r0qs
r0qs reviewed Jul 9, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
r0qs
r0qs reviewed Jul 9, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
r0qs
r0qs reviewed Jul 9, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
r0qs
r0qs reviewed Jul 9, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
This was referenced Jul 10, 2024
Draft
Draft
nikola-matic
nikola-matic reviewed Jul 15, 2024
View reviewed changes
libyul/YulName.h Outdated Show resolved Hide resolved
test/libyul/YulName.cpp Outdated Show resolved Hide resolved
test/libyul/YulName.cpp Outdated Show resolved Hide resolved
nikola-matic
nikola-matic reviewed Jul 16, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.cpp Show resolved Hide resolved
nikola-matic
nikola-matic previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cameel your turn.

libyul/YulName.cpp Outdated Show resolved Hide resolved
cameel
cameel reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the first pass. I'll need to take another looks but let's first get this stuff out of the way.

libyul/YulName.h Show resolved Hide resolved
libyul/YulName.h Outdated Show resolved Hide resolved
libyul/YulName.h Outdated Show resolved Hide resolved
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.h Outdated Show resolved Hide resolved
libyul/YulName.cpp Outdated Show resolved Hide resolved
libyul/YulName.h Show resolved Hide resolved
@clonker clonker mentioned this pull request Jul 19, 2024
Draft
5 tasks
@clonker clonker force-pushed the yul_name_repository branch 2 times, most recently from 28aaae3 to 324b21f Compare July 20, 2024 11:57
stackenbotten
stackenbotten reviewed Jul 20, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
stackenbotten
stackenbotten reviewed Jul 20, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
@clonker clonker force-pushed the yul_name_repository branch 4 times, most recently from 1ad1aee to b8c34bd Compare July 22, 2024 12:35
stackenbotten
stackenbotten reviewed Jul 25, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
ekpyron
ekpyron reviewed Aug 5, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
ekpyron
ekpyron reviewed Aug 5, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
ekpyron
ekpyron reviewed Aug 5, 2024
View reviewed changes
libyul/YulName.cpp Outdated Show resolved Hide resolved
@clonker clonker force-pushed the yul_name_repository branch 4 times, most recently from 86881e0 to d6d08bd Compare August 6, 2024 09:09
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 20, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 4, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 2, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 2, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 22, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 6, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackenbotten stackenbotten stackenbotten left review comments

@ekpyron ekpyron ekpyron left review comments

@r0qs r0qs r0qs left review comments

@cameel cameel cameel left review comments

@nikola-matic nikola-matic nikola-matic left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@clonker clonker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clonker @cameel @r0qs @ekpyron @nikola-matic @stackenbotten