Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable name collision in discovery recv_neighbours #43

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

janx
Copy link
Member

@janx janx commented Apr 25, 2016

Problem

In recv_neighbours of discovery.py, variable node is reused to get neighbours set, make node refer to the last neighbour instead of the packet sender.

Solution

Use a different variable _node to get neighbours.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.856% when pulling 918672e on janx:fix_recv_neighbours into 3121147 on ethereum:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants