Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: Don't assume the sender account exists #731

Merged
merged 1 commit into from
Nov 23, 2023
Merged

host: Don't assume the sender account exists #731

merged 1 commit into from
Nov 23, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 22, 2023

This change is basically refactoring with the goal not to access the call sender's account unnecessary.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #731 (01727ca) into master (9e9681d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   97.69%   97.70%   +0.01%     
==========================================
  Files         105      105              
  Lines        9665     9671       +6     
==========================================
+ Hits         9442     9449       +7     
+ Misses        223      222       -1     
Flag Coverage Δ
blockchaintests 62.23% <ø> (ø)
statetests 60.65% <100.00%> (ø)
statetests-silkpre 27.49% <70.58%> (-0.02%) ⬇️
unittests 95.51% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/host.cpp 93.59% <100.00%> (+0.49%) ⬆️
test/state/state.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_create_test.cpp 100.00% <100.00%> (ø)

This change is basically refactoring with the goal not to access
the call sender's account unnecessary.
@chfast chfast merged commit 0bcf0c5 into master Nov 23, 2023
25 checks passed
@chfast chfast deleted the state_sender branch November 23, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants