Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

print state root after json trace #4615

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

cdetrio
Copy link
Member

@cdetrio cdetrio commented Oct 20, 2017

This might break change logs, but it demonstrates the state root needed for standard traces.

@codecov-io
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #4615 into develop will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4615      +/-   ##
===========================================
+ Coverage    53.38%   53.49%   +0.11%     
===========================================
  Files         1608     1607       -1     
  Lines        69275    69277       +2     
  Branches      7093     7125      +32     
===========================================
+ Hits         36983    37061      +78     
+ Misses       31075    30990      -85     
- Partials      1217     1226       +9
Impacted Files Coverage Δ
test/tools/libtesteth/ImportTest.cpp 69.56% <0%> (-0.16%) ⬇️
...t/home/classic/iterator/impl/position_iterator.ipp 0% <0%> (-100%) ⬇️
CommonNet.h 0% <0%> (-100%) ⬇️
...0b/db97bd5/9d3cb74/Install/include/cryptopp/oids.h 0% <0%> (-100%) ⬇️
...it/home/classic/iterator/position_iterator_fwd.hpp 0% <0%> (-100%) ⬇️
...db97bd5/9d3cb74/Install/include/cryptopp/hrtimer.h 0% <0%> (-100%) ⬇️
...tall/include/boost/asio/detail/impl/socket_ops.ipp 1.88% <0%> (-98.12%) ⬇️
...spirit/home/classic/iterator/position_iterator.hpp 0% <0%> (-92.69%) ⬇️
Executive.h 0% <0%> (-91.67%) ⬇️
.../Install/include/boost/asio/ip/detail/endpoint.hpp 0% <0%> (-90%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f642b8...21ffce0. Read the comment docs.

@holiman
Copy link
Contributor

holiman commented Oct 20, 2017

👍

@chfast chfast requested a review from winsvega October 23, 2017 10:34
@winsvega
Copy link
Contributor

Have to check how --jsontrace is functioning after this check

@pirapira
Copy link
Member

@winsvega have you checked what you wanted to check?

@winsvega
Copy link
Contributor

looks like --statediff option requre Permanence::Uncommitted
this change affects only --jsontrace '' which seems to work just fine.

@gumb0
Copy link
Member

gumb0 commented Nov 23, 2017

What's the status of this, are we going to merge it? @winsvega

@winsvega winsvega merged commit 6a6376e into ethereum:develop Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants