Added feature for multi items support on RecyclerView. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blazvantur thanks for your pr, i will review your code at a recent free time |
|
Hey =) Sorry to bothering you. Did you manage to check my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using your library and I've got to the problem where I have to use different layouts inside of RecyclerView. So I added this feature to your library, so we can pass an array of layout resources into RecyclerViewSkeletonScreen.Builder and as soon we have this kind of array presented, the regular layout gets overridden with items from that array. Check if code makes sense to you, it will be really nice to have such a feature inside that library.
Chears! ;)