Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added the possibility to disable perPage select #75

Closed
wants to merge 1 commit into from
Closed

feat: added the possibility to disable perPage select #75

wants to merge 1 commit into from

Conversation

LeonneBrito
Copy link

Added the possibility to disable perPage select.

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gavmck
gavmck reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@gavmck gavmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for disabling? Why not just hide it?

@JoshTheWanderer
Copy link
Member

@gavmck it looks like this is related to #68

@JoshTheWanderer JoshTheWanderer added the question Further information is requested label Jan 31, 2024
@JoshTheWanderer JoshTheWanderer linked an issue Jan 31, 2024 that may be closed by this pull request
turn OFF the Per Page Dropdown and text #68
Closed
@gavmck
Copy link
Member

gavmck commented Feb 1, 2024

I think it would be better to hide the control away entirely, which can be done with CSS right now.

@gavmck gavmck closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavmck gavmck gavmck left review comments

Assignees

@LeonneBrito LeonneBrito

Labels
question Further information is requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

turn OFF the Per Page Dropdown and text
3 participants
@LeonneBrito @JoshTheWanderer @gavmck