docs: update broken links, fix outdated links #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lester Guerzon <[email protected]>
ahrtr
reviewed
Nov 3, 2023
|
Also in the main branch, the client/v2 package has been moved to client/internal/v2, so please remove it from https://etcd.io/docs/v3.6/integrations/ |
Signed-off-by: Lester Guerzon <[email protected]>
|
Thanks for the review points @ahrtr, PR ready for review again. |
serathius
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a PR to update some broken links in 3.5 integration documentation.
For versions 3.4 and earlier - I am not sure but I think
etcd/client/v3should be removed? If my understanding is correct, client v3 only came out with etcd 3.5, so it might be a good idea to not list it in the docs for earlier versions.Let me know what you think!