Add door name support #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With MQTT support for multiple doors and different access type. Access to the first door is mandatory to open the others. You cannot have permission to open a secondary door if you cannot open the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With MQTT support for multiple doors and different access type.
Access to the first door is mandatory to open the others. You cannot have permission to open a secondary door if you cannot open the first one, to change this behaviour it would mean to introduce a significant change in how MQTT messages are sent.
This PR adds only information to existing MQTT messages, while allowing doors to be completely independent would cause the behaviour to change, for example right now if someone has access denied to the first door, nothing happens. If we want to change this, we might start opening stuff that before would not open, I feel like this shouldn't change, even if it's a bit strange.
Maybe we can improve the UI to clarify this behaviour, but I wouldn't change it.