Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax IDF version dependency till v4.0 (IEC-67) #261

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

vikramdattu
Copy link
Contributor

qrcode component is mostly independent and can also be used with IDF v4.0 Relaxing the version dependency on IDF makes the component usable for projects with older IDFs.

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

  • Relax the IDF version dependency for qrcode component till IDF v4.0

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Relax IDF version dependency till v4.0 Relax IDF version dependency till v4.0 (IEC-67) Oct 27, 2023
@igrr
Copy link
Member

igrr commented Oct 27, 2023

Just keep in mind that we don't actually test anything older than IDF v4.3 in idf-extra-components, and we will remove v4.3 testing at the end of December when that release becomes EoL. So if the component becomes incompatible with the declared minimal supported IDF version, we won't notice this.

@vikramdattu
Copy link
Contributor Author

Just keep in mind that we don't actually test anything older than IDF v4.3 in idf-extra-components, and we will remove v4.3 testing at the end of December when that release becomes EoL. So if the component becomes incompatible with the declared minimal supported IDF version, we won't notice this.

@igrr I think that should be fine. Not having strong opinions here, but maybe we make some exceptions and have some of the components also get tested for the older IDF builds? (But again, that opens door for more and more components :( )

@vikramdattu vikramdattu force-pushed the support/qrcode_relax_idf_ver_dep branch from b374228 to 7a3a451 Compare January 5, 2024 14:19
@vikramdattu
Copy link
Contributor Author

@igrr as per pervious discussion, we should be okay with CI not running with older IDFs. Besides this particular component only use esp_err and esp_log.

@igrr igrr force-pushed the support/qrcode_relax_idf_ver_dep branch from 7a3a451 to 3123c00 Compare January 22, 2024 16:50
qrcode component is mostly independent and can be used for IDF 4.0 and later.
Relaxing the version dependency on IDF makes the component usable for projects with older IDFs.
@igrr igrr force-pushed the support/qrcode_relax_idf_ver_dep branch from 3123c00 to 28bac40 Compare January 23, 2024 09:46
@igrr igrr merged commit 66994c5 into espressif:master Jan 23, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants