You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
the MANIFEST.in is not currently included in the sdist: https://github.com/espressif/esptool/blob/master/MANIFEST.in#L11
This is not a problem when building wheel from sdist directly.
In Fedora, where we package esptool as RPM, this causes a failure to build wheel that includes the JSON stubs.
The issue is that we regenerate metadata before building the wheel (we call setuptools.build_meta.prepare_metadata_for_build_wheel(".")), which means the folder egg-info/ where the information about JSON files is stored, is deleted. The wheel is then built with the fresh dist-info which - at this point - have nowhere defined that is should include the JSON files too.
It's common for projects that define MANIFEST.in to include it into sdist. We've checked this will solve our issue too.
More Information
No response
Other Steps to Reproduce
No response
The text was updated successfully, but these errors were encountered:
Operating System
Fedora Linux 35-37
Esptool Version
4.2.1
Python Version
Python 3.10/3.11
Full Esptool Command Line that Was Run
No response
Esptool Output
No response
What is the Expected Behaviour?
Hello,
the MANIFEST.in is not currently included in the sdist: https://github.com/espressif/esptool/blob/master/MANIFEST.in#L11
This is not a problem when building wheel from sdist directly.
In Fedora, where we package esptool as RPM, this causes a failure to build wheel that includes the JSON stubs.
The issue is that we regenerate metadata before building the wheel (we call
setuptools.build_meta.prepare_metadata_for_build_wheel(".")
), which means the folderegg-info/
where the information about JSON files is stored, is deleted. The wheel is then built with the fresh dist-info which - at this point - have nowhere defined that is should include the JSON files too.It's common for projects that define MANIFEST.in to include it into sdist. We've checked this will solve our issue too.
More Information
No response
Other Steps to Reproduce
No response
The text was updated successfully, but these errors were encountered: