Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you include MANIFEST.in in sdist? (ESPTOOL-498) #767

Closed
befeleme opened this issue Aug 11, 2022 · 1 comment
Closed

Could you include MANIFEST.in in sdist? (ESPTOOL-498) #767

befeleme opened this issue Aug 11, 2022 · 1 comment

Comments

@befeleme
Copy link
Contributor

Operating System

Fedora Linux 35-37

Esptool Version

4.2.1

Python Version

Python 3.10/3.11

Full Esptool Command Line that Was Run

No response

Esptool Output

No response

What is the Expected Behaviour?

Hello,
the MANIFEST.in is not currently included in the sdist: https://github.com/espressif/esptool/blob/master/MANIFEST.in#L11
This is not a problem when building wheel from sdist directly.
In Fedora, where we package esptool as RPM, this causes a failure to build wheel that includes the JSON stubs.
The issue is that we regenerate metadata before building the wheel (we call setuptools.build_meta.prepare_metadata_for_build_wheel(".")), which means the folder egg-info/ where the information about JSON files is stored, is deleted. The wheel is then built with the fresh dist-info which - at this point - have nowhere defined that is should include the JSON files too.
It's common for projects that define MANIFEST.in to include it into sdist. We've checked this will solve our issue too.

More Information

No response

Other Steps to Reproduce

No response

@befeleme befeleme added the bug label Aug 11, 2022
@github-actions github-actions bot changed the title Could you include MANIFEST.in in sdist? Could you include MANIFEST.in in sdist? (ESPTOOL-498) Aug 11, 2022
@radimkarnis
Copy link
Collaborator

Hello @befeleme,

thanks for the detailed report and proposed solution!
I will fix this ASAP.

espressif-bot pushed a commit that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants