-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESP-NOW Arduino library #9395
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
f990db0
to
6630a6c
Compare
6630a6c
to
2c68fdc
Compare
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
Can't communicate when using AP mode. Currently investigating. EDIT: Figured it out. Not a problem with the Lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@P-R-O-C-H-Y - I've left a couple changes for your review.
Co-authored-by: Rodrigo Garcia <[email protected]>
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me-no-dev, @SuGlider PR is ready, all examples tested.
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master/ESP_NOW_Broadcast_Master.ino
Show resolved
Hide resolved
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave/ESP_NOW_Broadcast_Slave.ino
Outdated
Show resolved
Hide resolved
…duino-esp32 into feat/espnow-library
af6411d
to
51ce71f
Compare
const uint8_t * addr() const; | ||
bool addr(const uint8_t *mac_addr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did nobody reacted on the fact that this setter and getter missing the prefix get and set like the other getter/setters below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary and needed to be get/set. It's pretty straightforward what it does and how to use it. Its also well documented.
Description of Change
This PR adds an ESP-NOW library, which can be used for easier local network communication between devices.
Tests scenarios
Tested on multiple SoCs with the ESP-NOW examples included in this PR.
Related links