Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH: Support physical address auto detection #9313

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR changes ETH.begin's parameter phy_addr from uint8_t to int32_t to match the eth_phy_config_t.
This also enables using ETH_PHY_ADDR_AUTO as phy_addr in ETH.begin() to automatically get the phy address from the chip.

Tests scenarios

Tested only with SPI Ethernet for now. Will test next week with RMII Ethernet.

Related links

Closes #9311

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Mar 1, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-RC1 milestone Mar 1, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c6ecba0

@me-no-dev me-no-dev merged commit aed7b4f into espressif:master Mar 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support.
Projects
Development

Successfully merging this pull request may close these issues.

ESP_ETH_PHY_ADDR_AUTO not supported by arduino-esp32 - signedness problem
2 participants