Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RMT initialization code #8927

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Update RMT initialization code #8927

merged 4 commits into from
Nov 29, 2023

Conversation

diplfranzhoepfinger
Copy link
Contributor

  • Commented out setting interrupt priority for both TX and RX configurations in the RMT initialization code.

otherwise we get an Compile Error with esp-idf 5.1.1

@diplfranzhoepfinger
Update RMT initialization code
4a95c3b 
- Commented out setting interrupt priority for both TX and RX configurations in the RMT initialization code.
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

and you break it for anyone on 5.1.2. Proper fix would be to check the ESP-IDF version

@Jason2866
Copy link
Collaborator

why should be an outdated IDF version be supported?

@diplfranzhoepfinger
Copy link
Contributor Author

Cool.
https://github.com/espressif/esp-idf/releases/tag/v5.1.2
5.1.2 is here.

@SuGlider
Copy link
Collaborator

@diplfranzhoepfinger - I changed your PR to include the IDF 5.1.x version check...

@SuGlider
Copy link
Collaborator

It could be useful when using Arduino as IDF component with any IDF 5.1.x version.

@diplfranzhoepfinger
Copy link
Contributor Author

Cool done.

@SuGlider SuGlider self-assigned this Nov 27, 2023
@SuGlider SuGlider added this to the 3.0.0 milestone Nov 27, 2023
@VojtechBartoska VojtechBartoska modified the milestones: 3.0.0, 3.0.0-Aplha3 Nov 28, 2023
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Nov 28, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 28, 2023
@me-no-dev me-no-dev merged commit b303cb4 into espressif:master Nov 29, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees

@SuGlider SuGlider

Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.
8 participants
@diplfranzhoepfinger @CLAassistant @me-no-dev @Jason2866 @SuGlider @lucasssvaz @P-R-O-C-H-Y @VojtechBartoska