Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WiFi Bandwidth Setting Methods for AP and STA modes. #7619

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

gonzabrusco
Copy link
Contributor


Description of Change

Now you can control the bandwidth of the WiFi in AP and STA modes. Before this change, the WiFi always defaulted to HT40 (at least on my ESP32). Not you can control if you want to use HT20 or HT40. This is not tested, but I expect the HT20 working mode to have a better range.

Tests scenarios

I tested this on a devkit and also on a custom board with an ESP32.

Related links

#6624

@mrengineer7777
Copy link
Collaborator

As a side effect this also starts SoftAP (AP) or WiFi (STA) modes. I vote for checking WiFi.mode() rather than starting AP or STA.

@gonzabrusco
Copy link
Contributor Author

gonzabrusco commented Dec 26, 2022

I did this that way because if SoftAP or STA is not enabled, then the bandwidth IDF call gets ignored. I expected that if somebody is setting the WiFi bandwidth, then I guess it's about to use it... so why not enable it? That's what other methods in these classes do.

@CLAassistant
Copy link

CLAassistant commented May 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VojtechBartoska VojtechBartoska added the Area: WiFi Issue related to WiFi label Nov 28, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Nov 28, 2023
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Nov 28, 2023
@me-no-dev me-no-dev merged commit ac1c001 into espressif:master Nov 29, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi Status: Review needed Issue or PR is awaiting review
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants