Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update camera example for support LED Intensity #7533

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Update camera example for support LED Intensity #7533

merged 3 commits into from
Dec 8, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Reworked CameraWebServer example to add LED intensity support which use Arduino LEDC API.
In the camera_pins.h I have added definition of LED_GPIO_NUM on boards that I was able to find the LED pin in data sheet.
in the app_httpd.cpp I have added definition of CONFIG_LED_ILLUMINATOR_ENABLED 1 to enable LED Intensity.

If the LED_GPIO_NUM pin is not defined, the LED intensity will be disabled.
If CONFIG_LED_ILLUMINATOR_ENABLED 0, the LED intensity will be disabled even if LED_GPIO_NUM is defined.

Tests scenarios

Tested on ESP32-EYE (LED enabled) board and ESP32-S3-EYE (LED disabled).

Related links

Closes #6790

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Example Issue is related to specific example. label Nov 29, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 29, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Nov 29, 2022
Closed
@VojtechBartoska VojtechBartoska added this to the 2.0.6 milestone Nov 30, 2022
SuGlider
SuGlider approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider merged commit ba68f31 into espressif:master Dec 8, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the Update-CameraWebServer-with-LEDsupport branch April 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@PilnyTomas PilnyTomas Awaiting requested review from PilnyTomas

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Type: Example Issue is related to specific example.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.

LED Intensity support is missed in the example CameraWebServer
3 participants
@P-R-O-C-H-Y @SuGlider @VojtechBartoska