Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CHANNEL in ESPNow example #7104

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Aug 9, 2022

Description of Change

ESPNow example could not work properly because of the unaligned CHANNEL hardcoded in the example.
This simple fix set them both in Master and Slave to 1.

Tests scenarios

Master on ESP32 DevKit with WROOM-32D
Slave on DevKit with WROWER-B
Arduino-ESP32 core version 2.0.4
Arduino IDE version 1.8.19

Master's serial output:

Found 5 devices 
Found a Slave.
1: Slave_1 [xx:xx:xx:xx:xx:xx] (-27)
Slave Found, processing..
Slave Status: Pair success
Sending: 1
Send Status: Success
Last Packet Sent to: xx:xx:xx:xx:xx:xx
Last Packet Send Status: Delivery Success

Found 4 devices 
Found a Slave.
1: Slave_1 [xx:xx:xx:xx:xx:xx] (-25)
Slave Found, processing..
Slave Status: Already Paired
Sending: 2
Send Status: Success
Last Packet Sent to: xx:xx:xx:xx:xx:xx
Last Packet Send Status: Delivery Success

Slave's serial output:

ESPNow Init Success
Last Packet Recv from: xx:xx:xx:xx:xx:xx
Last Packet Recv Data: 1

Last Packet Recv from: xx:xx:xx:xx:xx:xx
Last Packet Recv Data: 2

Related links

Related to #2653 but NOT solving the main problem - could not replicate.

@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label Aug 9, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.5 milestone Aug 10, 2022
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit d9ac65f into espressif:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants