use esptool v3.3 for S3 CI test #6498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could be used for all. Nice would be releasing in Platformio registry.
me-no-dev
reviewed
Mar 29, 2022
| @@ -109,7 +109,7 @@ else | |||
| replace_script+="data['packages']['toolchain-xtensa-esp32']['optional']=True;" | |||
| replace_script+="data['packages']['toolchain-xtensa-esp32s3']['optional']=False;" | |||
| replace_script+="data['packages']['tool-esptoolpy']['owner']='tasmota';" | |||
| replace_script+="data['packages']['tool-esptoolpy']['version']='https://github.com/tasmota/esptool/releases/download/v3.2.1/esptool-3.2.1.zip';" | |||
| replace_script+="data['packages']['tool-esptoolpy']['version']='https://github.com/tasmota/esptool/releases/download/v3.3/esptool-3.3.zip';" | |||
There was a problem hiding this comment.
questions is: Should we not do this earlier? So all chips use that same version?
|
Yes, but i do not want to be invasive in your scripts. I saw you use my build and i updated that. |
me-no-dev
added a commit
that referenced
this pull request
Mar 29, 2022
) * Update toolchain to gcc8_4_0-esp-2021r2-patch3 * Update esptool to 3.3 * Remove old files * Update package_esp32_index.template.json * use esptool v3.3 (#6498) could be used for all. Nice would be releasing in Platformio registry. * Switch toolchain for PIO CI Co-authored-by: Jason2866 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could be used for all. Nice would be releasing in Platformio registry.
Checklist
This entire section above can be deleted if all items are checked.
Summary
Please describe your proposed PR and what it contains.
Impact
Please describe impact of your PR and it's function.
Related links
Please provide links to related issue, PRs etc.