Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ADC API doc + simple example #6301

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Added ADC API doc + simple example #6301

merged 4 commits into from
Feb 23, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

Summary

Added documentation for ADC peripheral.
Added example AnalogRead

Impact

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Feb 18, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 18, 2022
me-no-dev
me-no-dev reviewed Feb 21, 2022
View reviewed changes
docs/source/api/adc.rst
This function is used to set the attenuation for all channels.

Default is 11db.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth mentioning what is the maximum input voltage for each attenuation setting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :)

pedrominatel
pedrominatel reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @P-R-O-C-H-Y.

docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
@P-R-O-C-H-Y
Copy link
Member Author

P-R-O-C-H-Y commented Feb 22, 2022 •
edited
Loading

PTAL @P-R-O-C-H-Y.

@pedrominatel
All mentioned edits done.

@pedrominatel pedrominatel self-requested a review February 22, 2022 08:34
pedrominatel
pedrominatel approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit a135169 into espressif:master Feb 23, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the docs_adc branch April 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@pedrominatel pedrominatel pedrominatel approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-R-O-C-H-Y @pedrominatel @me-no-dev