Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UM FeatherS2 Neo to boards.txt and variants folder #5615

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Added UM FeatherS2 Neo to boards.txt and variants folder #5615

merged 1 commit into from
Aug 31, 2021

Conversation

UnexpectedMaker
Copy link
Contributor

As title states, just adding my newest FeatherS2 Neo board to the boards list with the appropriate variants folder.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

@UnexpectedMaker can you sign the cla please?

@me-no-dev me-no-dev merged commit 44c1198 into espressif:master Aug 31, 2021
@UnexpectedMaker
Copy link
Contributor Author

@UnexpectedMaker can you sign the cla please?

I just signed it... but I'm sure I have done that already.
Maybe it was for the ESP-IDF? Do I need to sign per repo? I thought it would have been for the GitHub org.

@me-no-dev
Copy link
Member

it's per repo :) you just made the 2.0.0 release

@UnexpectedMaker
Copy link
Contributor Author

it's per repo :) you just made the 2.0.0 release

Ahh, that makes sense then!

Yes, I know, thanks heaps for merging it!!!! How exciting.... It's been a long journey to get 2.0.0 out, congrats to you and the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants