Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board ID as build flag #8634

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Board ID as build flag #8634

merged 4 commits into from
Jul 27, 2022

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jul 13, 2022

Use {_id} in mDNS response instead of the {build.board}, adds extra build flag -DARDUINO_BOARD_ID="{_id}"

For example

$ arduino-cli.exe board list
Port          Protocol Type              Board Name                FQBN                       Core
xxx.xxx.x.xxx network  Network Port      LOLIN(WEMOS) D1 R2 & mini esp8266com:esp8266:d1_mini esp8266com:esp8266

resolve #7759

When using IDE or `arduino-cli board list`, show full board name and FQBN
```
$ arduino-cli.exe board list
Port          Protocol Type              Board Name                FQBN                       Core
xxx.xxx.x.xxx network  Network Port      LOLIN(WEMOS) D1 R2 & mini esp8266com:esp8266:d1_mini esp8266com:esp8266
```
Also add `description` field to the mDNS response containing the
original `{build.board}` string value.

resolve esp8266#7759
@mcspr
Copy link
Collaborator Author

mcspr commented Jul 13, 2022

...or, just replace the {build.board} with {_id}. without adding yet another flag
just not sure whether changing its value matters anywhere but the IDE discovery, or if any user code might expect / use it in any way

@d-a-v d-a-v merged commit 06f34ed into esp8266:master Jul 27, 2022
@mcspr mcspr deleted the mdns/board-id-and-desc branch July 27, 2022 21:33
@mcspr mcspr added this to the 3.1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mDNS discovery with IDE cannot detect the board name
2 participants