Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current netif address in NetBIOS response #8622

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Use current netif address in NetBIOS response #8622

merged 7 commits into from
Jun 29, 2022

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jun 27, 2022

fix for NetBIOS only working if WIFI in STA mode and not AP mode

resolve #8139
resolve #8140

@mcspr
Copy link
Collaborator Author

mcspr commented Jun 27, 2022

yet, wireshark seems to think we have a malformed packet when asking for name via ip
not related to the issue at hand thoug

@mcspr mcspr merged commit a2c8a63 into master Jun 29, 2022
@mcspr mcspr deleted the pr8140-redo branch June 29, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP8266NetBIOS library only works in wifi STA mode, and not in wifi AP
3 participants