Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform.txt: Override python3 anon pipe encoding to utf-8 for 'tools/sizes.py' #8570

Merged
merged 1 commit into from
May 16, 2022
Merged

platform.txt: Override python3 anon pipe encoding to utf-8 for 'tools/sizes.py' #8570

merged 1 commit into from
May 16, 2022

Conversation

jjsuwa-sys3175
Copy link
Contributor

d-a-v
d-a-v approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change w/linux

@jjsuwa-sys3175
Copy link
Contributor Author

no change w/linux

thx

a little concern: -X utf8 requires python 3.7 or later

@mcspr mcspr merged commit 1bb041b into esp8266:master May 16, 2022
@mcspr mcspr added this to the 3.1 milestone May 16, 2022
@jjsuwa-sys3175 jjsuwa-sys3175 deleted the python3-utf8 branch May 16, 2022 22:49
@mcspr
Copy link
Collaborator

mcspr commented May 16, 2022

Thanks. Also a good reminder to double-check any python scripts to force text encoding :)
BTW, what happens with legacy cmd.exe when invoking the script manually?

@jjsuwa-sys3175
Copy link
Contributor Author

jjsuwa-sys3175 commented May 16, 2022 •
edited
Loading

BTW, what happens with legacy cmd.exe when invoking the script manually?

(default codepage (cp932) setting on Win7 ja-JP)
scrnshot

(cp437 setting in Win7 ja-JP)
scrnshot

@mcspr mcspr mentioned this pull request Mar 25, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjsuwa-sys3175 @mcspr @d-a-v