Fix utf-8 encoding #8565
Merged
Fix utf-8 encoding #8565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue posted to commit esp8266@d1d4212#r73517358
|
LGTM IMHO touching utime should open by encoding-independent manner eg. binary mode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue posted to commit
d1d4212#r73517358
Should resolve UnicodeDecodeError: multibyte-byte.
I don't have an environment to test this; however, this version still works on my machine.
The python docs say "UTF-8 is one of the most commonly used encodings, and Python often defaults to using it."
Hmm, "often" wasn't often enough. I set encoding to "utf-8" for all
open()calls. Is there a chance that doing all of them will cause a problem?