Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, calloc now fails on extra-large request. #8482

Merged
merged 4 commits into from
Feb 12, 2022

Conversation

mhightower83
Copy link
Contributor

Fixes #8481 (comment)

umm_calloc, now fails on extra-large request.

Added code to handle multiply overflow in umm_calloc.
Added code to handle add overflow in umm_poison_*

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mhightower83
Copy link
Contributor Author

@d-a-v I have one more push coming. I missed the calloc entry that libc uses. I am not sure if this is just overkill.

@d-a-v d-a-v merged commit e6fc76a into esp8266:master Feb 12, 2022
@mhightower83 mhightower83 deleted the pr-calloc-overflow branch April 21, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

umm_calloc undetected multiply overflow/wrap
2 participants