I2C pin assignment fix

[DanKoloff]

There was a typo in I2C pin assignment, SCL was set to GPIO #4 instead of GPIO #14, The schematic can be seen here: https://github.com/OLIMEX/ESP8266/blob/master/HARDWARE/MOD-WIFI-ESP8266-DEV/MOD-WiFi-ESP8266-DEV%20revision%20B1/MOD-WiFi-ESP8266-DEV_Rev_B1.pdf

[JAndrassy]

esp8266 Arduino Wire library does software I2C. it doesn't matter what pair of pins is used. for most variants io 4 and io 5 are the defaults

[TD-er]

@JAndrassy As I understand it, this is the definition meant for a specific board.
See also this previous commit for the file, giving a bit more context: e1ca870

[JAndrassy]

@JAndrassy As I understand it, this is the definition meant for a specific board.
See also this previous commit for the file, giving a bit more context: e1ca870

and what? defaults can't change after 2 years. and pin 14 is used for SPI so it would be not a good default

[DanKoloff]

@JAndrassy Is this some joke I don't get or the heat wave got to you? variants/modwifi is made specifically for Olimex ESP8266-MOD-WIFI-DEV by a contributor and he made a typo for the I2C pins that are specifically routed to a specific connector available only in Olimex ESP8266-MOD-WIFI-DEV, this doesn't affect other boards.

[earlephilhower]

Relax, guys, we're all just trying to do the right thing here and not break the repo.

While I don't see it explicitly labeled as-such, if you do look at the PDF schematic you can see the 2K pullup on GPIO14 which does make sense for I2C, @JAndrassy . It's also only for the modwifi variant so this won't affect any board not using this setup.

So, seeing as I can see @DanKoloff is responsible for the Olimex repos and the change meshes with the schematic, LGTM.

[DanKoloff]

We will try to assign somebody to fix the variants for all Olimex ESP8266 boards, it seems we didn't commit properly here. Just want to ask if it is usually ok to change folder names, this modwifi is kind of vague and also misleading but alas it wasn't our doing.

[d-a-v]

Pull requests to improve this repository are always welcome.
We try to keep the repository backward compatible.
When board makers / maintainers like you seem to be update board definitions, we usually can't do better than trusting them.

[JAndrassy]

I don't see how I could I know that @DanKoloff represents Olimex.