Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build directory for libbearssl.a #4736

Merged
merged 4 commits into from
May 24, 2018

Conversation

earlephilhower
Copy link
Collaborator

Simple git submodule and makefile for building the bearssl library
from source in the Arduino tree.

@earlephilhower
Copy link
Collaborator Author

@d-a-v , I tried to copy your setup in lwip2 for this. Can you eyeball things and see if I've got it right? Thanks!

@d-a-v
Copy link
Collaborator

d-a-v commented May 16, 2018

That works for me !
libssl.a is regenerated with make install
What do you think of adding a make merge-upstream or so to manually add the remote upstream and do the git pull (for test purpose only) ?

@devyte
Copy link
Collaborator

devyte commented May 18, 2018

LGTM!!

Simple git submodule and makefile for building the bearssl library
from source in the Arduino tree.
@earlephilhower
Copy link
Collaborator Author

Several fixes/updates per the gitter discussion:

  • Fixed the makefile install to also copy over the headers
  • Add a git remote to upstream on submodule init, and a merge-upstream makefile target
  • Generate a git hash ID on install, and include the hash in the ESP.getFullVersion() call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants