Improve xtask on Windows
#1632
Merged
Improve xtask on Windows
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
commented
May 28, 2024
jessebraham
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint-packageswasn't working on Windows becauseOUT_DIRwas set to a UNC-path (Which causes problems like this one: dtolnay/rustversion#50 (comment)While
include!'s docs say:The provided path is interpreted in a platform-specific way at compile time. So, for instance, an invocation with a Windows path containing backslashes \ would not compile correctly on Unix. (See https://doc.rust-lang.org/std/macro.include.html)
it often works with
/on Windows because of https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry (File I/O functions in the Windows API convert "/" to "" as part of converting the name to an NT-style name, except when using the "\?" prefix)While
rustversionalready fixed that, other crates didn't and runningcargo xtask lint-packagesdidn't work on Windows. Even if the currently used crates would all be fixed, we might start using an unfixed one in future.