-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Configuring Additional Lint Targets with .eslintrc
#20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea overall. I left a few suggestions/questions.
Co-Authored-By: Teddy Katz <[email protected]>
Co-Authored-By: Teddy Katz <[email protected]>
Thank you for the feedback! I updated this RFC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question but overall I'm in favor of this change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be very helpful for the airbnb config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense and likely matches intuitive expectations. Would we plan to deprecate --ext
and remove it or turn it into a no-op at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect extended configs (shareable configs or plugin configs), or just direct project configs?
If this affects extended configs, are we concerned about config/plugin authors changing file overrides in their configs and potentially breaking users' linting configs?
I don't think we deprecate
This affects extended configs. It's the purpose -- make providing shareable configs and plugin that verify other kinds of files than
I think it's a breaking change regardless of this feature. People can use |
…12677) * Breaking: lint `overrides` files (fixes #10828, refs eslint/rfcs#20) * update docs * sort for tests See also: #12700 (comment)
…s#20) (eslint#12677) * Breaking: lint `overrides` files (fixes eslint#10828, refs eslint/rfcs#20) * update docs * sort for tests See also: eslint#12700 (comment)
This was separated from #13. I hope this enhancement to be on ESLint 7.0.0 line.
Summary
This proposal adds the ability to specify additional target files into configuration files. This enhancement will solve the pain that people have to use the
--ext
option with wanted file extensions even if they use plugins which support additional file types.Related Issues
eslintrc
or other config files