Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Configuring Additional Lint Targets with .eslintrc #20

Merged
merged 8 commits into from
Jun 20, 2019

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented May 11, 2019

Rendered RFC

This was separated from #13. I hope this enhancement to be on ESLint 7.0.0 line.

Summary

This proposal adds the ability to specify additional target files into configuration files. This enhancement will solve the pain that people have to use the --ext option with wanted file extensions even if they use plugins which support additional file types.

Related Issues

@mysticatea mysticatea added enhancement New feature or request Initial Commenting This RFC is in the initial feedback stage labels May 11, 2019
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea overall. I left a few suggestions/questions.

designs/2019-additional-lint-targets/README.md Outdated Show resolved Hide resolved
designs/2019-additional-lint-targets/README.md Outdated Show resolved Hide resolved
designs/2019-additional-lint-targets/README.md Outdated Show resolved Hide resolved
designs/2019-additional-lint-targets/README.md Outdated Show resolved Hide resolved
designs/2019-additional-lint-targets/README.md Outdated Show resolved Hide resolved
mysticatea and others added 2 commits May 12, 2019 06:56
Co-Authored-By: Teddy Katz <[email protected]>
Co-Authored-By: Teddy Katz <[email protected]>
@mysticatea
Copy link
Member Author

Thank you for the feedback! I updated this RFC.

@mysticatea mysticatea added feature and removed enhancement New feature or request labels May 12, 2019
@mysticatea mysticatea added Final Commenting This RFC is in the final week of commenting and removed Initial Commenting This RFC is in the initial feedback stage labels Jun 7, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question but overall I'm in favor of this change 👍

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful for the airbnb config.

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and likely matches intuitive expectations. Would we plan to deprecate --ext and remove it or turn it into a no-op at some point?

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect extended configs (shareable configs or plugin configs), or just direct project configs?

If this affects extended configs, are we concerned about config/plugin authors changing file overrides in their configs and potentially breaking users' linting configs?

@mysticatea
Copy link
Member Author

Would we plan to deprecate --ext and remove it or turn it into a no-op at some point?

I don't think we deprecate --ext for now because --ext .js has the role that disables adding target files of overrides entries.

Does this affect extended configs (shareable configs or plugin configs), or just direct project configs?

This affects extended configs. It's the purpose -- make providing shareable configs and plugin that verify other kinds of files than .js more comfortable.

If this affects extended configs, are we concerned about config/plugin authors changing file overrides in their configs and potentially breaking users' linting configs?

I think it's a breaking change regardless of this feature. People can use --ext option or glob patterns along with shareable configs or plugins, and updating overrides entries affects theirs.

@mysticatea mysticatea merged commit f1fe954 into master Jun 20, 2019
@mysticatea mysticatea deleted the 2019-additional-lint-targets branch June 20, 2019 09:53
@mysticatea mysticatea added the breaking change This RFC contains breaking changes label Oct 14, 2019
mysticatea added a commit to eslint/eslint that referenced this pull request Dec 17, 2019
btmills pushed a commit to eslint/eslint that referenced this pull request Jan 17, 2020
…12677)

* Breaking: lint `overrides` files (fixes #10828, refs eslint/rfcs#20)

* update docs

* sort for tests

See also: #12700 (comment)
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
…s#20) (eslint#12677)

* Breaking: lint `overrides` files (fixes eslint#10828, refs eslint/rfcs#20)

* update docs

* sort for tests

See also: eslint#12700 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This RFC contains breaking changes feature Final Commenting This RFC is in the final week of commenting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants