-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce a way to suppress violations #119
Open
softius
wants to merge
27
commits into
eslint:main
Choose a base branch
from
softius:designs-2024-baseline-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a99c456
Add RFC for baseline support
softius f9b3976
Fix typos
softius c9a718c
Add question about warnings
softius 4d73750
Convert relative to full paths
softius 9e035f1
Replace --generate-baseline with --baseline/-location
softius ed01be1
Add more implementation details, add relative paths to CWD
softius d5411af
Update designs/2024-baseline-support/README.md
softius 98779dc
Remove references to the deprecated engine
softius b343ddb
Rename default baseline file to eslint-baseline.json
softius ad5343d
Include more implementation details
softius 485f684
Add link for no-explicit-any
softius 70a7c56
Always update the baseline to update addressed violations
softius 4462ce6
Update designs/2024-baseline-support/README.md
softius 1a1cbba
Add more details for matching against the baseline, and keeping the b…
softius 71ee661
Fix lists formatting
softius 2d4dc84
Minor adjs
softius dc2d940
First iteration to replace the concept of baseline with suppressions.
softius b8a1cf7
Fix header and other minor adjustments
softius 0c3d9a4
Simplify language
softius 4fea00e
Revise return types
softius 42d8b95
Minor cleanup
softius bff622d
Allow to pass multiple rules
softius 48e9d0a
Fix typo
softius 46cf6ae
Update designs/2024-baseline-support/README.md
softius a94a50d
Fix typo
softius 861f1a4
Use block comments
softius 566e3b9
More details about prune-suggestions and how the filtering works.
softius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Simplify language
- Loading branch information
commit 0c3d9a48d08bb480d1c9f7a25e0ae47fc0e37eb1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, will there be an error message, and what would it look like? Technically, will it be a lint message passed to the formatter along with other lint messages for the file, or a separate output?