-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove eslintrc export from eslint-config-eslint #18400
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
I'm not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! It's working fine on my local vscode.
"rollup-plugin-node-polyfills", | ||
|
||
// FIXME: not sure why is eslint-config-eslint reported as unused | ||
"eslint-config-eslint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be fixed by putting eslint.config.js
in the entry.
and L35~38 can also be removed. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be fixed by putting
eslint.config.js
in the entry.
I tried that first, in 9f0f9b6, but it didn't work. Not sure why.
https://github.com/eslint/eslint/actions/runs/8845405029/job/24289216911
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and L35~38 can also be removed. :)
Done in f67403a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like @aladdin-add to verify his changes before merging.
@mdjermanovic it has been merged, ready to release |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Removes eslintrc export from eslint-config-eslint so that we can publish v10 without it.
What changes did you make? (Give an overview)
packages/eslint-config-eslint/eslintrc.js
directly into the root.eslintrc.js
.packages/eslint-config-eslint/eslintrc.js
file and the corresponding export frompackages/eslint-config-eslint/package.json
..eslintrc.js
.Is there anything you'd like reviewers to focus on?