fix: Correctly consume RuleTester statics #15507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment:
What parser (default,
@babel/eslint-parser
,@typescript-eslint/parser
, etc.) are you using? espreePlease show your full configuration:
N/A
What did you do? Please include the actual source code causing the issue.
runkit repl
What did you expect to happen?
This test should log out
MyCustomRuleTesterSubclass has been customized!
What actually happened? Please include the actual, raw output from ESLint.
No console log.
If you instead set the
it
directly onRuleTester
, it works.This bug is caused because
RuleTester
directly references itself within its instance method instead of usingthis.constructor
to reference the correct static context:eslint/lib/rule-tester/rule-tester.js
Lines 980 to 1002 in 03ac8cf
What changes did you make? (Give an overview)
RuleTester
to usethis.constructor
instead ofRuleTester
to access static members.Is there anything you'd like reviewers to focus on?
This was reported by a user of
@typescript-eslint
.Fixes: typescript-eslint/typescript-eslint#4422