Update: Improve error message for fatal fixer errors #13120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[x] Other, please explain:
When the autofixer outputs broken code, the rule tester rightfully hard fails the test.
However, the error current message can be pretty vague as it relies upon the error message from the parser. Some of the parser errors can be explicit and easy to trace, and others can be useless without an error location.
For example, the following invalid code
'const a = "1";`'`
Produces this error message in both espree and typescript-eslint
Which results in this test failure:
This is especially problematic for fixer failure, because you cannot actually see the fixer output anywhere. So the above error message is impossible to action.
Usually I just patch my local eslint install to
console.log
the fixer output, but I finally figured it was probably just better if this was part of core.This change simply includes the code in the output so it's possible to see what code caused the error: