Fix: object-shorthand providing invalid fixes for typescript #12260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Related: typescript-eslint/typescript-eslint#124
The bug is that currently the fixer adds extra parentheses when fixing a TS arrow function with a return type:
This happens because the rule currently searches backwards from the
=>
to find a)
, to determine if it should wrap the arguments in parentheses. It obviously instead finds a return type annotation, hence the breakage.What changes did you make? (Give an overview)
Adjusted the fix algorithm for arrow functions so that it searches from the start of the arrow function expression instead.
I added a TS-specific test for this - happy to remove it if you don't want the burden.