Docs: improve jsdoc, better for typings #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmills
requested changes
Mar 27, 2021
2 tasks
btmills
reviewed
Mar 30, 2021
There was a problem hiding this comment.
Thanks for making those changes! I'm glad you were able to create typedefs without pulling in TypeScript definitions.
I merged #177 earlier tonight, and I'm sorry that it caused a couple merge conflicts. I believe I was able to fix those with GitHub's built-in merge conflict editor, but please make sure I did that correctly. It also removed the parent node from the traversal step, so I left two inline suggestions to remove the ASTParentNode type that I'll let you apply after looking over them.
Once you've confirmed the merge conflict fixes, this'll be good to merge! Sorry again about the extra iteration from merge conflicts.
|
@btmills I've rebased just now. |
btmills
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split part of #178
@btmills