Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for N #130

Merged
merged 8 commits into from
Oct 2, 2022
Merged

Add support for N #130

merged 8 commits into from
Oct 2, 2022

Conversation

Julien-R44
Copy link
Collaborator

The generation script works great man, it's awesome 馃殌

Everything seems to work on my end correctly, I tested with a pnpm link, and everything is typed.

If you validate that I've done everything correctly, I'll add a couple of other plugins as well

Shinigami92
Shinigami92 requested changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 馃憤
You definitely did the generate process right 馃檪

Need to refresh my mind and check if you didn't missed anything outside the rules/extends folder.
e.g. settings or parser-options need to be manually added and are not covered by the generate process.

package.json Outdated Show resolved Hide resolved
src/extends/index.d.ts Outdated Show resolved Hide resolved
src/rules/n/no-extraneous-import.d.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the enhancement New feature or request label Oct 1, 2022
@Shinigami92 Shinigami92 linked an issue Oct 1, 2022 that may be closed by this pull request
Replace eslint-plugin-node by eslint-plugin-n #129
Closed
@Shinigami92 Shinigami92 changed the title feat: add eslint-plugin-n Add support for N Oct 1, 2022
@Shinigami92
Copy link
Collaborator

Run pnpm run lint && pnpm run format && pnpm run check 馃檪

@Julien-R44
Copy link
Collaborator Author

Julien-R44 commented Oct 1, 2022 •
edited
Loading

Dude it's weird but I don't have this error in local
image

Even a pnpm lint --fix does not change anything. pnpm format too

Will try to fix it manually

@Shinigami92
Copy link
Collaborator

馃コ

I will check and merge it tomorrow, hope that's okay

@Julien-R44
Copy link
Collaborator Author

Well, that's super weird. This is the first time I've seen this. a lint error in CI, but not in local. Anyway !

@Julien-R44
Copy link
Collaborator Author

Awesome, thanks for the review dude!

@Shinigami92
Copy link
Collaborator

I have updated all dependencies and generated some updated rules for the existing ones.
Please update your PRs / rebase them.

@Shinigami92 Shinigami92 self-requested a review October 2, 2022 14:51
@Shinigami92 Shinigami92 merged commit d436979 into eslint-types:main Oct 2, 2022
@Julien-R44 Julien-R44 deleted the feat/eslint-plugin-n branch October 2, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@Julien-R44 Julien-R44

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace eslint-plugin-node by eslint-plugin-n
2 participants
@Julien-R44 @Shinigami92