Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint-plugin-node by eslint-plugin-n #129

Closed
Julien-R44 opened this issue Oct 1, 2022 · 2 comments · Fixed by #130
Closed

Replace eslint-plugin-node by eslint-plugin-n #129

Julien-R44 opened this issue Oct 1, 2022 · 2 comments · Fixed by #130
Labels
enhancement New feature or request

Comments

@Julien-R44
Copy link
Collaborator

Hey !

I just discovered the project, and it's really great to make custom eslint configurations. Really, an incredible job, well done 👏

I realized that you added support for eslint-plugin-node. which is cool, but this plugin has not been maintained for a while. People are starting to migrate to eslint-plugin-n which is a fork. And it's possible that a repo transfer will be done soon :

mysticatea/eslint-plugin-node#341

I don't know exactly all the changes between the two repositories, all I know is that many things are in common.

So we have two choices, either totally drops the first one for the second plugin, or support both. I would be more in favor of dropping eslint-plugin-node.

I can't promise anything because I'm a little short on time right now, but I'm willing to propose a PR after I get your opinion.

Thanks again for this fabulous project which is a life saver!

@Shinigami92 Shinigami92 added the enhancement New feature or request label Oct 1, 2022
@Shinigami92
Copy link
Collaborator

For now, I would just prefer to support both
So just add the new plugin and run the generate script (see package.json scripts)
Then ignore ALL errors that were thrown by the generate tool and revert all non plugin related changes
Then check if everything coming from the plugin looks fine

@Julien-R44
Copy link
Collaborator Author

Okay cool, thanks. I'm going to try to watch it this weekend.

I'm going to check out the repo a bit to see how the generation works and how much of it you have to write by hand.

Because there are some other eslint plugins that I'd like to have support for. If I can add that in passing, that would be awesome

@Shinigami92 Shinigami92 linked a pull request Oct 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants