Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R15 callbacks #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

R15 callbacks #10

wants to merge 6 commits into from

Conversation

jlouis
Copy link
Contributor

@jlouis jlouis commented Mar 2, 2012

What title says. Provides Callbacks in R15 style so they can be dialyzer-checked.

@jlouis
Copy link
Contributor Author

jlouis commented Mar 2, 2012

I added something so we now require R15.

Yes, this breaks backwards compatibility, so we may want to not pull the request. On the other hand, I'd rather that we move on to R15 quickly :)

@uwiger
Copy link
Contributor

uwiger commented Mar 2, 2012

Let me ponder this for a while. Not sure who uses jobs and if this would cause breakage. In general, I'm in favor of the change.

@jlouis
Copy link
Contributor Author

jlouis commented Mar 2, 2012

We don't need to pull the branch right away. It shouldn't be that hard to keep up-to-date and it should help my dialyzer runs by quite a lot :P In the case you want to ponder, we may need to pull the rebar hint about erl_first_files though as this is needed to make rebar not complain about missing behaviours.

fpesti pushed a commit to travelping/jobs that referenced this pull request Feb 10, 2023
compatibility with erlang 18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants