fix(repl): prevent panic when deleting globalThis.closed property (de…

…noland#24014)
eryue0220 · Jun 18, 2024 · 4b83ce8 · 4b83ce8
1 parent 6819c3d
commit 4b83ce8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/cli/tools/repl/session.rs b/cli/tools/repl/session.rs
@@ -99,6 +99,9 @@ Object.defineProperty(globalThis, "{0}", {{
  lastThrownError: undefined,
  inspectArgs: Deno[Deno.internal].inspectArgs,
  noColor: Deno.noColor,
+ get closed() {{
+ return typeof globalThis.closed === 'undefined' ? false : globalThis.closed;
+ }}
  }},
 }});
 Object.defineProperty(globalThis, "_", {{
@@ -299,8 +302,9 @@ impl ReplSession {
  }
 
  pub async fn closing(&mut self) -> Result<bool, AnyError> {
+ let expression = format!(r#"{}.closed"#, *REPL_INTERNALS_NAME);
  let closed = self
- .evaluate_expression("(this.closed)")
+ .evaluate_expression(&expression)
  .await?
  .result
  .value