fix(inspector): crash on "Debugger.setBlackboxPatterns" (denoland#24204)

Closes denoland#24196 --------- Co-authored-by: Divy Srivastava <[email protected]>
eryue0220 · Jun 14, 2024 · 184a85e · 184a85e
1 parent 9092a23
commit 184a85e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -44,7 +44,7 @@ repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
 deno_ast = { version = "=0.39.2", features = ["transpiling"] }
-deno_core = { version = "0.288.0" }
+deno_core = { version = "0.289.0" }
 
 deno_bench_util = { version = "0.150.0", path = "./bench_util" }
 deno_lockfile = "0.20.0"

diff --git a/tests/integration/inspector_tests.rs b/tests/integration/inspector_tests.rs
@@ -499,12 +499,14 @@ async fn inspector_does_not_hang() {
  .send_many(&[
  json!({"id":1,"method":"Runtime.enable"}),
  json!({"id":2,"method":"Debugger.enable"}),
+ json!({"id":3,"method":"Debugger.setBlackboxPatterns","params":{"patterns":["/node_modules/|/bower_components/"]}}),
  ])
  .await;
  tester.assert_received_messages(
  &[
  r#"{"id":1,"result":{}}"#,
- r#"{"id":2,"result":{"debuggerId":"#
+ r#"{"id":2,"result":{"debuggerId":"#,
+ r#"{"id":3,"result":"#,
  ],
  &[
  r#"{"method":"Runtime.executionContextCreated","params":{"context":{"id":1,"#
@@ -513,21 +515,21 @@ async fn inspector_does_not_hang() {
  .await;
 
  tester
- .send(json!({"id":3,"method":"Runtime.runIfWaitingForDebugger"}))
+ .send(json!({"id":4,"method":"Runtime.runIfWaitingForDebugger"}))
  .await;
  tester
  .assert_received_messages(
- &[r#"{"id":3,"result":{}}"#],
+ &[r#"{"id":4,"result":{}}"#],
  &[r#"{"method":"Debugger.paused","#],
  )
  .await;
 
  tester
- .send(json!({"id":4,"method":"Debugger.resume"}))
+ .send(json!({"id":5,"method":"Debugger.resume"}))
  .await;
  tester
  .assert_received_messages(
- &[r#"{"id":4,"result":{}}"#],
+ &[r#"{"id":5,"result":{}}"#],
  &[r#"{"method":"Debugger.resumed","params":{}}"#],
  )
  .await;