Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a command to select the package manager #14

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

raisiqueira
Copy link
Member

@raisiqueira raisiqueira commented Jul 7, 2023

  • Write unit tests for the new command.

@raisiqueira raisiqueira requested a review from luigieai July 7, 2023 01:42
Copy link
Member

@luigieai luigieai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ! This feature put us on a higher level in flexibility. But how we can safely implement tests so we know all package managers are properly handled? We can do using both app testing and github actions, but IDK what should be better! Besides that, I do not see anything wrong here.

@devmozao
Copy link

devmozao commented Oct 2, 2023

ces sabem do que se trata esse frozen error aq? @raisiqueira @luigieai

Signed-off-by: Rai Siqueira <[email protected]>
Signed-off-by: Rai Siqueira <[email protected]>
Signed-off-by: Rai Siqueira <[email protected]>
@raisiqueira raisiqueira self-assigned this Oct 3, 2023
@raisiqueira raisiqueira added the enhancement New feature or request label Oct 3, 2023
@raisiqueira raisiqueira marked this pull request as ready for review October 3, 2023 22:47
@raisiqueira
Copy link
Member Author

Nice work ! This feature put us on a higher level in flexibility. But how we can safely implement tests so we know all package managers are properly handled? We can do using both app testing and github actions, but IDK what should be better! Besides that, I do not see anything wrong here.

The package manager selector is just a "cosmetic" feature, basically this new command just removes the package-lock.json file to avoid errors when the developer runs the install command using another package manager (like Yarn or PNPM).

Copy link
Member

@luigieai luigieai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's gooooo!

@raisiqueira raisiqueira merged commit 559a6ce into main Oct 3, 2023
1 check passed
@raisiqueira raisiqueira deleted the feat/select-package-manager branch October 3, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants